Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Don't drop late blocks #2274

Merged
merged 13 commits into from
Mar 4, 2024
Merged

IF: Don't drop late blocks #2274

merged 13 commits into from
Mar 4, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Mar 1, 2024 •
edited
Loading

  • Instead of dropping blocks when producing, incorporate blocks received while producing into the fork database.
    • Potentially fork switch to newly incorporated blocks before producing a block
    • Use block id instead of block number for irreversible so that correct fork branch is made irreversible

Resolves #2159

@heifner heifner added the OCI Work exclusive to OCI team label Mar 1, 2024
@heifner heifner marked this pull request as ready for review March 1, 2024 21:58
@heifner heifner linked an issue Mar 1, 2024 that may be closed by this pull request
IF: Don't drop late blocks #2159
Closed
greg7mdp
greg7mdp reviewed Mar 3, 2024
View reviewed changes
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: INTERNALS
summary: Incorporate blocks received while producing into fork database. Previously late blocks were dropped.
Note:end

linh2931
linh2931 reviewed Mar 4, 2024
View reviewed changes
libraries/chain/controller.cpp Show resolved Hide resolved
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/chain/controller.cpp Show resolved Hide resolved
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
plugins/producer_plugin/producer_plugin.cpp Outdated Show resolved Hide resolved
@heifner heifner merged commit 8fee9b8 into hotstuff_integration Mar 4, 2024
26 checks passed
@heifner heifner deleted the GH-2159-late-blocks branch March 4, 2024 21:20
This was referenced Mar 4, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IF: Don't drop late blocks
4 participants
@heifner @ericpassmore @greg7mdp @linh2931